fix(kfluxbugs-1142) make related image check work with yaml and json #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirgim
requested review from
jsztuka,
dirgim,
hongweiliu17,
Josh-Everett,
kasemAlem and
dheerajodha
|
/retest |
kasemAlem
approved these changes
Jun 25, 2024
|
approved, |
Josh-Everett
approved these changes
Jun 25, 2024
dirgim
reviewed
Jun 26, 2024
Signed-off-by: Ryan Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
opm renderto gather related images instead ofyqandjq. This streamlines the code and makes the related images check compatible with edge cases such as aconfig.jsonthat contains yaml or a document with yaml and json nested within one another.